Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/9480#issuecomment-153926546
My 2 cents, Common Expression Elimination is a very interesting/useful
optimization, and I did the same thing for Shark quite long time ago, for my
understanding, we probably need to add additional expression/operator for
Sequential/Conditional execution. instead of do it directly via code gen.
e.g.
```
(a+b) + (a+b) => Add(Add(a, b), Add(a, b)) => Sequential(Alias(a1, Add(a,
b)), Add(a1,a1))
```
So we can eliminate the common operations for Intermediate Representation
(IR), which will make the codegen part code more clean and simple.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
