Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9256#discussion_r43981603
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/State.scala 
---
    @@ -0,0 +1,141 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.streaming
    +
    +/**
    + * Abstract class for getting and updating the tracked state in the 
`trackStateByKey` operation of
    + * [[org.apache.spark.streaming.dstream.PairDStreamFunctions pair 
DStream]] and
    + * [[org.apache.spark.streaming.api.java.JavaPairDStream]].
    + * {{{
    + *
    + * }}}
    + */
    +sealed abstract class State[S] {
    +
    +  /** Whether the state already exists */
    +  def exists(): Boolean
    +
    +  /**
    +   * Get the state if it exists, otherwise wise it will throw an exception.
    +   * Check with `exists()` whether the state exists or not before calling 
`get()`.
    +   */
    +  def get(): S
    +
    +  /**
    +   * Update the state with a new value. Note that you cannot update the 
state if the state is
    +   * timing out (that is, `isTimingOut() return true`, or if the state has 
already been removed by
    +   * `remove()`.
    +   */
    +  def update(newState: S): Unit
    --- End diff --
    
    minor nit: but prefer `def update(state: S): Unit` since it's implied by 
the semantics of update that it is new.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to