Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9432#discussion_r44003082
  
    --- Diff: sbin/start-master.sh ---
    @@ -23,6 +23,26 @@ if [ -z "${SPARK_HOME}" ]; then
       export SPARK_HOME="$(cd "`dirname "$0"`"/..; pwd)"
     fi
     
    +# Figure out where Spark is installed
    +FWDIR="$(cd "`dirname "$0"`"/..; pwd)"
    --- End diff --
    
    This is wrong now, though; like other scripts it should be using 
`SPARK_HOME` not `FWDIR`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to