Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/9165#issuecomment-154077899
  
    Hm, by the end here it seems like 90% of the changes are whitespace 
changes. It's enough compared to the small functional change that I think it's 
worth re-doing.
    
    In the end how does this sort? numerically, but what about IDs like 
"driver"? does it sort on something like the leading prefix of digits?
    
    Does it still need server-side sorting if so? I see that's added but it 
just sorts lexicographically.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to