Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9476#discussion_r44043747
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/DStreamGraph.scala ---
@@ -167,7 +167,8 @@ final private[streaming] class DStreamGraph extends
Serializable with Logging {
* safe remember duration which can be used to perform cleanup
operations.
*/
def getMaxInputStreamRememberDuration(): Duration = {
- inputStreams.map { _.rememberDuration }.maxBy { _.milliseconds }
+ // If an InputDStream is not used, its `rememberDuration` will be null
and we can ignore them
+ inputStreams.filter(_.rememberDuration !=
null).map(_.rememberDuration).maxBy(_.milliseconds)
--- End diff --
> Simpler to map then filter since you can then just .filter(_ != null)?
Good point. Updated.
> Also does this create a corner case where none are non-null? do you need
to map null to a default of 0 or something or otherwise handle this?
Because there is at least one `OutputDStream`, there must be at least one
non-null `InputDStream.rememberDuration`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
