Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9227#discussion_r44058401
--- Diff:
network/common/src/main/java/org/apache/spark/network/server/RpcHandler.java ---
@@ -54,4 +54,11 @@ public abstract void receive(
public void connectionTerminated(TransportClient client) { }
public void exceptionCaught(Throwable cause, TransportClient client) { }
+
+ /**
+ * Whether to close idle connections
+ */
+ public boolean isCloseIdleConnections() {
--- End diff --
nit: the method name sounds a little weird. maybe just
`closeIdleConnections()`.
I'm also a little bit torn about putting this in `RpcHandler`. It's not
necessarily tied to RPCs. How about a new constructor argument in
`TransportContext`? I'd suggest a configuration, but we don't really want users
to configure this (or do we?).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
