Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9421#discussion_r44067306
  
    --- Diff: 
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
 ---
    @@ -216,6 +226,25 @@ private[kinesis] class KinesisReceiver[T](
         shardIdToLatestStoredSeqNum.get(shardId)
       }
     
    +  /** Pass the setCheckpointer request to the checkpointer. */
    +  private[kinesis] def setCheckpointerForShardId(
    --- End diff --
    
    setCheckpointer is sufficient. Scala docs should just say "set the 
checkpoint that will be used to checkpoint sequence numbers to DynamoDB". 
Whether there is a "setCheckpointer method or not on some other checkpointer - 
these are implementation details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to