Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8592#discussion_r44086403
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -298,6 +300,8 @@ class SqlParser extends AbstractSparkSQLParser with
DataTypeParser {
throw new AnalysisException(s"invalid function approximate($s)
$udfName")
}
}
+ | COLLECT_SET ~> "(" ~> expression <~ ")" ^^ { case exp =>
CollectSet(exp) }
+ | COLLECT_LIST ~> "(" ~> expression <~ ")" ^^ { case exp =>
CollectList(exp) }
--- End diff --
We don't need to bake things into the parser anymore. Instead register
them in
[FunctionRegistery](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L117)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
