Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9344#discussion_r44162017
--- Diff: core/src/main/scala/org/apache/spark/memory/MemoryManager.scala
---
@@ -306,7 +194,7 @@ private[spark] abstract class MemoryManager(conf:
SparkConf, numCores: Int) exte
val cores = if (numCores > 0) numCores else
Runtime.getRuntime.availableProcessors()
// Because of rounding to next power of 2, we may have safetyFactor as
8 in worst case
val safetyFactor = 16
- val size = ByteArrayMethods.nextPowerOf2(maxExecutionMemory / cores /
safetyFactor)
+ val size = ByteArrayMethods.nextPowerOf2(maxOnHeapExecutionMemory /
cores / safetyFactor)
--- End diff --
Ah, good catch: if the Tungsten memory mode is off-heap, then this should
use a different max.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
