Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9380#issuecomment-154509839 @rxin We still need to run some benchmark. The formulation is simple and fixed, and hence codegen won't bring much performance gain. @JihongMA Could you address the comments on `NaN` vs `null`?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org