Github user davies commented on the pull request:
https://github.com/apache/spark/pull/9480#issuecomment-154518695
This looks pretty good to me, just a few minor comments. Should we have a
benchmark to see is there any regression for tiny common subexpression? If not
much, then we don't need to have a cost based one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
