Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9143#discussion_r44187373
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
---
@@ -488,7 +491,12 @@ class ReceiverTracker(ssc: StreamingContext,
skipReceiverLaunch: Boolean = false
registerReceiver(streamId, typ, host, executorId,
receiverEndpoint, context.senderAddress)
context.reply(successful)
case AddBlock(receivedBlockInfo) =>
- context.reply(addBlock(receivedBlockInfo))
+ if (WriteAheadLogUtils.isBatchingEnabled(ssc.conf, isDriver =
true)) {
+ val f =
Future(addBlock(receivedBlockInfo))(walBatchingThreadPool)
+ f.onComplete(result =>
context.reply(result.get))(walBatchingThreadPool)
--- End diff --
Right, if it is running. So from what I can understand the code in the
`Future` itself runs in one thread, and the `onComplete` code runs in another.
Are both these no longer safe to run or is it safe to add the block - my take
is both are not safe to run.
We should probably need synchronization to ensure this safety then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
