Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9385#issuecomment-154640515 `Expression` instances have two different kinds of equality: - `equals` full equality, i.e. capitalization, qualifiers, etc. This is important for example to know if a tree transformation has reached fixed point. - `semanticEquals` equivalent in execution (i.e. will return the same result) If you ran into problems adding qualifiers to `equals` then I think it is likely that that code should actually be using `semanticEquals`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org