Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/9143#discussion_r44236121
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
---
@@ -488,7 +493,28 @@ class ReceiverTracker(ssc: StreamingContext,
skipReceiverLaunch: Boolean = false
registerReceiver(streamId, typ, host, executorId,
receiverEndpoint, context.senderAddress)
context.reply(successful)
case AddBlock(receivedBlockInfo) =>
- context.reply(addBlock(receivedBlockInfo))
+ if (WriteAheadLogUtils.isBatchingEnabled(ssc.conf, isDriver =
true)) {
+ val f = Future {
+ synchronized {
+ if (active) {
--- End diff --
You are calling the whole `addBlock` in `synchronized`. Isnt that what we
wanted to avoid originally, so that the method does not block other threads why
the WAL is being written (that why we removed synchronized inside the whole
method of addBlock and made it very specific on a few lines only)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
