Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9576#discussion_r44348401
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
 ---
    @@ -1235,6 +1232,26 @@ class HiveQuerySuite extends HiveComparisonTest with 
BeforeAndAfter {
     
       }
     
    +  test("lookup hive UDF in another thread") {
    +    val e = intercept[AnalysisException] {
    +      range(1).selectExpr("not_a_udf()")
    +    }
    +    assert(e.getMessage.contains("undefined function not_a_udf"))
    +    var success = false
    +    val t = new Thread("test") {
    +      override def run(): Unit = {
    +        val e = intercept[AnalysisException] {
    +          range(1).selectExpr("not_a_udf()")
    --- End diff --
    
    How about we add a comment to let readers know what's the original 
exception without this fix? We can add this comment when we merge the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to