Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/9512#issuecomment-155334662
This looks fine (i.e. LGTM). However, we could also look into actually
shading asm ourselves in our published artifacts, similar to how we now shade
jetty and other things. I'm fine to just use this already shaded one too
though. Seems to do no harm and will allow us to work with Java 8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
