GitHub user dskrvk opened a pull request:
https://github.com/apache/spark/pull/9600
[SPARK-6990] [Build] Add Java linting script; mix minor warnings
Invoke Checkstyle and print any errors to the console, failing the step.
Use Google's style rules modified according to
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
Some important checks are disabled (see TODOs in `checkstyle.xml`) due to
multiple violations being present in the codebase.
Suggest fixing those TODOs in a separate PR(s).
Also fix some of the minor violations that didn't require sweeping changes.
cr: @nchammas, @ScrapCodes
> I state that the contribution is my original work, and I license the work
to the project under the project's open source license.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dskrvk/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9600.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9600
----
commit 374e55f61cdaac948a34a2b261b92992a0d1641c
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-10T16:56:46Z
[SPARK-6990] Add Java linting script
Invoke Checkstyle and print any errors to the console, failing the step.
Use Google's style rules modified according to
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
Some important checks are disabled (see TODOs in checkstyle.xml) due to
multiple violations being present in the codebase.
commit add6f45a86e1e14f05b8cd7d992e41166d69c382
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-10T16:57:20Z
[SPARK-6990] Fix some Checkstyle warnings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
