Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9599#discussion_r44444404
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala ---
    @@ -58,6 +58,11 @@ abstract class Aggregator[-A, B, C] {
       def reduce(b: B, a: A): B
     
       /**
    +   * Merge two intermediate values
    +   */
    +  def merge(b1: B, b2: B): B
    --- End diff --
    
    @mateiz JFYI, I missed adding this in the first iteration, but I think we 
need it if we are going to do multilevel aggregation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to