Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9512#discussion_r44464743
  
    --- Diff: project/SparkBuild.scala ---
    @@ -560,6 +570,14 @@ object Unidoc {
       )
     }
     
    +object Java8TestSettings {
    +  import BuildCommons._
    +
    +  lazy val settings = Seq(
    +    compilerJVMVersion := "1.8"
    --- End diff --
    
    Subtlety: this setting will break the `java8` tests when running on Scala 
2.10.x, which does not support the emission of Java 8 bytecode. For this 
reason, we need separate settings for configuring the scalc and javac target 
JVM versions and need to only set scalac to 1.8 when running Scala 2.11.4 or 
higher.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to