Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9585#discussion_r44475000
--- Diff: scalastyle-config.xml ---
@@ -150,6 +150,14 @@ This file is divided into 3 sections:
// scalastyle:on println]]></customMessage>
</check>
+ <check customId="visiblefortesting" level="error"
class="org.scalastyle.file.RegexChecker" enabled="true">
+ <parameters><parameter
name="regex">@VisibleForTesting</parameter></parameters>
+ <customMessage><![CDATA[
+ @VisibleForTesting is banned due to tendency of making Spark Shell
malfunction. In most cases,
+ you should describe purpose for testing in scala doc.
--- End diff --
I would just say
```
@VisibleForTesting causes classpath issues. Please note this in the java
doc instead (SPARK-11615).
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
