Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9566#discussion_r44479350
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/AggregationQuerySuite.scala
---
@@ -545,19 +576,21 @@ abstract class AggregationQuerySuite extends
QueryTest with SQLTestUtils with Te
| count(distinct value2),
| sum(distinct value2),
| count(distinct value1, value2),
+ | longProductSum(distinct value1, value2),
--- End diff --
To be more specific, my question is not for the semantic of
`longProductSum` since an aggregate function can define its own semantic on how
to handle nulls. My question is for our rewriter. Since we use an aggregate to
do distinct, for the case above, seems we will get 4 distinct input rows, which
makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
