Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9297#discussion_r44481829
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
    @@ -150,7 +151,14 @@ private[spark] object SparkUI {
           appName: String,
           basePath: String,
           startTime: Long): SparkUI = {
    -    create(None, conf, listenerBus, securityManager, appName, basePath, 
startTime = startTime)
    +    val sparkUI = create(
    +      None, conf, listenerBus, securityManager, appName, basePath, 
startTime = startTime)
    +    JsonProtocol.eventRegisters.foreach { eventRegister =>
    +      val listener = eventRegister.getListener()
    +      listenerBus.addListener(listener)
    +      eventRegister.attachUITab(listener, sparkUI)
    --- End diff --
    
    This doesn't look right. Won't this attach, e.g. the SQL tab to every 
application in the history server, regardless of whether the app used SQL or 
not?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to