Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/9605#discussion_r44495040
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/util/WriteAheadLogSuite.scala
---
@@ -406,21 +392,26 @@ class BatchedWriteAheadLogSuite extends
CommonWriteAheadLogTests(
// The queue.take() immediately takes the 3, and there is nothing left
in the queue at that
// moment. Then the promise blocks the writing of 3. The rest get
queued.
- promiseWriteEvent(batchedWal, event1, 3L)
- // rest of the records will be batched while it takes 3 to get written
- promiseWriteEvent(batchedWal, event2, 5L)
- promiseWriteEvent(batchedWal, event3, 8L)
- promiseWriteEvent(batchedWal, event4, 12L)
- promiseWriteEvent(batchedWal, event5, 10L)
+ writeAsync(batchedWal, event1, 3L)
+ eventually(timeout(1 second)) {
+ assert(blockingWal.isBlocked)
--- End diff --
Add `assert(batchedWal.invokePrivate(queueLength()) === 0)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
