Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7841#discussion_r44500802
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedData.scala ---
    @@ -273,6 +280,60 @@ class GroupedData protected[sql](
       def sum(colNames: String*): DataFrame = {
         aggregateNumericColumns(colNames : _*)(Sum)
       }
    +
    +  /**
    +    * (Scala-specific) Pivots a column of the current [[DataFrame]] and 
preform the specified
    +    * aggregation.
    +    * {{{
    +    *   // Compute the sum of earnings for each year by course with each 
course as a separate column
    +    *   df.groupBy($"year").pivot($"course", "dotNET", 
"Java").agg(sum($"earnings"))
    +    *   // Or without specifying column values
    +    *   df.groupBy($"year").pivot($"course").agg(sum($"earnings"))
    +    * }}}
    +    * @param pivotColumn Column to pivot
    +    * @param values Optional list of values of pivotColumn that will be 
translated to columns in the
    +    *               output data frame. If values are not provided the 
method with do an immediate
    +    *               call to .distinct() on the pivot column.
    +    * @since 1.6.0
    +    */
    +  @scala.annotation.varargs
    +  def pivot(pivotColumn: Column, values: String*): GroupedData = groupType 
match {
    +    case _: GroupedData.PivotType =>
    +      throw new UnsupportedOperationException("repeated pivots are not 
supported")
    +    case GroupedData.GroupByType =>
    +      val pivotValues = if (values.nonEmpty) {
    +        values
    +      } else {
    +        // Get the distinct values of the column and sort them so its 
consistent
    +        df.select(pivotColumn.cast(StringType))
    --- End diff --
    
    If we cast values to strings, in `EqualTo(pivotColumn, Literal(value)` (in 
analyzer), we will create string literals. My concern is that turning those 
values to strings may make `EqualTo(pivotColumn, Literal(value)` return wrong 
results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to