Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9490#discussion_r44516708
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
    @@ -431,7 +436,7 @@ abstract class HadoopFsRelation 
private[sql](maybePartitionSpec: Option[Partitio
               val hdfsPath = new Path(path)
               val fs = hdfsPath.getFileSystem(hadoopConf)
               val qualified = hdfsPath.makeQualified(fs.getUri, 
fs.getWorkingDirectory)
    -
    +          inputExists = inputExists && fs.exists(qualified)
    --- End diff --
    
    This can be quite expensive since each `fs.exists(qualified)` call invokes 
`FileSystem.getFileStatus()`, which is an RPC call. On the other hand, we've 
already called `fs.listStatus(qualified)` below. Would be better to merge these 
two.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to