Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9608#discussion_r44539552
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -810,7 +810,7 @@ private[spark] object Utils extends Logging {
        * Get the local machine's URI.
        */
       def localHostNameForURI(): String = {
    -    customHostname.getOrElse(InetAddresses.toUriString(localIpAddress))
    +    sys.env.get("SPARK_PUBLIC_DNS").getOrElse( 
customHostname.getOrElse(InetAddresses.toUriString(localIpAddress)) )
    --- End diff --
    
    sorry, not got much insight there, except failing fast on "" is good. It 
should really be the job of the code downstream to recognise and react to the 
usual config problems of trying to listen on an invalid hostname or port 0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to