Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9627#discussion_r44560192
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala
---
@@ -63,19 +61,19 @@ class EquivalentExpressions {
}
/**
- * Adds the expression to this datastructure recursively. Stops if a
matching expression
+ * Adds the expression to this data structure recursively. Stops if a
matching expression
* is found. That is, if `expr` has already been added, its children are
not added.
* If ignoreLeaf is true, leaf nodes are ignored.
*/
def addExprTree(root: Expression, ignoreLeaf: Boolean = true): Unit = {
val skip = root.isInstanceOf[LeafExpression] && ignoreLeaf
- if (!skip && root.deterministic && !addExpr(root)) {
+ if (!skip && !addExpr(root)) {
root.children.foreach(addExprTree(_, ignoreLeaf))
--- End diff --
indent one more space? I will check this when I merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
