Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9623#discussion_r44576806
--- Diff:
core/src/test/scala/org/apache/spark/deploy/RPackageUtilsSuite.scala ---
@@ -60,11 +64,9 @@ class RPackageUtilsSuite extends SparkFunSuite with
BeforeAndAfterEach {
}
}
- def beforeAll() {
- System.setProperty("spark.testing", "true")
- }
-
override def beforeEach(): Unit = {
+ super.beforeEach()
+ System.setProperty("spark.testing", "true")
--- End diff --
I think it's marginally easier to reason about the interaction between
BeforeAndAfterEach and ResetSystemProperties.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
