Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/9373#discussion_r44577472
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/util/WriteAheadLogSuite.scala
---
@@ -199,6 +198,45 @@ class FileBasedWriteAheadLogSuite
--- End diff --
Since some of the changes were in `FileBasedWriteAheadLog*Reader`, these
should be unit tested as well. Probably add it CommonWALTests. Simple unit test
that writes to the log to get WAL segments, deletes the files and then tries to
read it (similar to the test "handling file errors while reading rotating logs")
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
