Github user colorant commented on a diff in the pull request:
https://github.com/apache/spark/pull/1273#discussion_r14544536
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -141,7 +141,7 @@ class HadoopRDD[K, V](
// local process. The local cache is accessed through
HadoopRDD.putCachedMetadata().
// The caching helps minimize GC, since a JobConf can contain ~10KB
of temporary objects.
// synchronize to prevent ConcurrentModificationException
(Spark-1097, Hadoop-10456)
- broadcastedConf.synchronized {
+ broadcastedConf.value.value.synchronized {
--- End diff --
regard conf , it is wrapped in SerializableWritable which enforce it to be
a Writable, I think it won't be a null , or exception already been thrown
somewhere before here. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
