Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9633#discussion_r44614090
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -102,8 +103,20 @@ public synchronized void kill() {
disconnect();
--- End diff --
I was initially worried that this needs to be in a `try` block but it
doesn't look like `disconnect()` is capable of throwing any exceptions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
