GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/9678
[SPARK-11712] [ML] Make spark.ml LDAModel be abstract
Per discussion in the initial Pipelines LDA PR
[https://github.com/apache/spark/pull/9513], we should make LDAModel abstract
and create a LocalLDAModel. This code simplification should be done before the
1.6 release to ensure API compatibility in future releases.
CC @feynmanliang @mengxr
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkbradley/spark lda-pipelines-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9678.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9678
----
commit 2545c89d8b48cf41dc1d76c1a35ead51e7b181ee
Author: Joseph K. Bradley <[email protected]>
Date: 2015-11-11T01:32:31Z
partial implementation, but hit issue with lazy val
commit 3c97e418283d92fb26322e63a568d6f491ad0068
Author: Joseph K. Bradley <[email protected]>
Date: 2015-11-12T21:04:42Z
refactored spark.ml LDAModel to be abstract
commit 9f39384131b1e0e236ac6d9c65698f93112aac34
Author: Joseph K. Bradley <[email protected]>
Date: 2015-11-12T21:07:11Z
doc fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
