Github user squito commented on the pull request:
https://github.com/apache/spark/pull/9610#issuecomment-156244415
you can take this test case if you like:
https://github.com/squito/spark/blob/SPARK-8029_first_wins/core/src/test/scala/org/apache/spark/ShuffleSuite.scala#L351
I'd also add more test cases to cover the various paths through the output
commit code. And I think that `ShuffleWriter.write` should at least include a
comment explaining the need for shuffle writers to write to a tmp file and
atomically move them to the final place, since its not obvious why that would
be necessary, and I guess there isn't any other good place to stick the
explanation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
