Github user feynmanliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9678#discussion_r44720656
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
    @@ -468,7 +452,37 @@ class LDAModel private[ml] (
     /**
      * :: Experimental ::
      *
    - * Distributed model fitted by [[LDA]] using Expectation-Maximization (EM).
    + * Local (non-distributed) model fitted by [[LDA]].
    + *
    + * This model stores the inferred topics only; it does not store info 
about the training dataset.
    + */
    +@Since("1.6.0")
    +@Experimental
    +class LocalLDAModel private[ml] (
    +    uid: String,
    +    vocabSize: Int,
    +    @Since("1.6.0") override protected val oldLocalModel: OldLocalLDAModel,
    --- End diff --
    
    Does a `protected val` in a private constructor need a Since annotation? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to