Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/9661#discussion_r44727600
--- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
@@ -176,15 +179,17 @@ private[spark] object HighlyCompressedMapStatus {
// From a compression standpoint, it shouldn't matter whether we track
empty or non-empty
--- End diff --
ah I see, I think I hadn't realized this before -- so even after calling
`runOptimize`, the memory usage may be different vs. flipped bits?
In any case, I agree, this comment needs to be modified -- along w/ the
[comment at line
124](https://github.com/apache/spark/blob/branch-1.5/core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala#L125),
but I guess we need to wait for the other details to shake out to figure out
exactly how to update them both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
