Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9610#discussion_r44741545
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriter.java ---
@@ -248,8 +250,7 @@ void forceSorterToSpill() throws IOException {
*
* @return the partition lengths in the merged file.
*/
- private long[] mergeSpills(SpillInfo[] spills) throws IOException {
- final File outputFile = shuffleBlockResolver.getDataFile(shuffleId,
mapId);
+ private long[] mergeSpills(SpillInfo[] spills, File outputFile) throws
IOException {
--- End diff --
This is only used in 1 place so we don't need to change the method
signature here. We can just do the `Utils.tempFileWith` in this method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
