Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9610#discussion_r44748592
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala ---
@@ -93,6 +154,31 @@ private[spark] class IndexShuffleBlockResolver(conf:
SparkConf) extends ShuffleB
} {
out.close()
}
+
+ val dataFile = getDataFile(shuffleId, mapId)
+ // Note: there is only one IndexShuffleBlockResolver per executor
+ synchronized {
+ val existedLengths = checkIndexAndDataFile(indexFile, dataFile,
lengths.length)
+ if (existedLengths != null) {
+ // Use the lengths of existed output for MapStatus
+ System.arraycopy(existedLengths, 0, lengths, 0, lengths.length)
+ dataTmp.delete()
+ indexTmp.delete()
+ } else {
+ if (indexFile.exists()) {
+ indexFile.delete()
+ }
+ if (dataFile.exists()) {
+ dataFile.delete()
+ }
+ if (!indexTmp.renameTo(indexFile)) {
+ throw new IOException("fail to rename data file " + indexTmp + "
to " + indexFile)
+ }
+ if (dataTmp != null && dataTmp.exists() &&
!dataTmp.renameTo(dataFile)) {
+ throw new IOException("fail to rename data file " + dataTmp + "
to " + dataFile)
+ }
--- End diff --
This will slowdown the normal path, I think it's not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
