Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9651#discussion_r44751717
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
 ---
    @@ -152,32 +157,59 @@ private[sql] object PartitioningUtils {
       private[sql] def parsePartition(
           path: Path,
           defaultPartitionName: String,
    -      typeInference: Boolean): (Option[PartitionValues], Option[Path]) = {
    +      typeInference: Boolean,
    +      basePaths: Set[Path]): (Option[PartitionValues], Option[Path]) = {
         val columns = ArrayBuffer.empty[(String, Literal)]
         // Old Hadoop versions don't have `Path.isRoot`
         var finished = path.getParent == null
    -    var chopped = path
    -    var basePath = path
    +    // currentPath is the current path that we will use to parse partition 
column value.
    +    var currentPath = path
    +    // childPath will be the child of currentPath in the loop below.
    +    var childPath = path
    --- End diff --
    
    Seems we will not need childPath anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to