Github user Tarrasch commented on the pull request:
https://github.com/apache/spark/pull/9647#issuecomment-156347814
> I don't know that in general Spark scripts work at all with zsh.
You launch a binary, you don't source a script. The shell you invoke a
binary from doesn't matter. So yes, given that the scripts are passed the
correct parameters, it works from any shell.
> Why single quote and not double?
With single quotes it is clear that there is no variable interpolation
going on. This is not my own convention. Puppet's linter for example rejects
double-quotes if you don't interpolate variables.
> In the end, won't the few zsh users out there immediately understand the
variance and fix it?
Yea. In this Pull Request I'm fixing it.
Besides. When you say "it works for bash". You mean "it works for bash
default options". The same with zsh. I'm sure bash will not accept the unquoted
`local[4]` in some modes. Adding the single quotes should make it work for all
modes in all (sensible) shells.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
