GitHub user dskrvk opened a pull request:
https://github.com/apache/spark/pull/9696
[SPARK-6990] [Build] Add Java linting script; mix minor warnings
This replaces the botched PR https://github.com/apache/spark/pull/9600
Invoke Checkstyle and print any errors to the console, failing the step.
Use Google's style rules modified according to
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
Some important checks are disabled (see TODOs in `checkstyle.xml`) due to
multiple violations being present in the codebase.
Suggest fixing those TODOs in a separate PR(s).
Also fix some of the minor violations that didn't require sweeping changes.
cr: @JoshRosen, @pwendell
> I state that the contribution is my original work, and I license the work
to the project under the project's open source license.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dskrvk/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9696.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9696
----
commit c6bab96d3f958d413373789e6e790b98d4dd195a
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-10T16:56:46Z
[SPARK-6990] Add Java linting script
Invoke Checkstyle and print any errors to the console, failing the step.
Use Google's style rules modified according to
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
Some important checks are disabled (see TODOs in checkstyle.xml) due to
multiple violations being present in the codebase.
commit 59e84dc5435dea27ad7efb82ff3f1c5a28fa8ec5
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-13T16:53:16Z
[SPARK-6990] Remove whitespace after '>'
Closing '>' and method name shouldn't have whitespace between them,
according
to
http://checkstyle.sourceforge.net/config_whitespace.html#GenericWhitespace
commit 20de73e85b4c8fe4cb4edebd0d564964c8525a0b
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-10T16:57:20Z
[SPARK-6990] Fix some Checkstyle warnings
commit 6a2c1439eb2ed56de25fc3f45f448664a9162329
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-11T14:52:19Z
[SPARK-6990] Suppress Checkstyle for TimSort
The code was copied from a third-party source and needs to be in sync with
that, so we shouldn't make our own modifications to it.
The file contains some style violations, so suppress the checks.
commit 67ffb934b259ab5dae4b7fb8a03fd71e77cfbda2
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-11T14:58:41Z
[SPARK-6990] Fix some Checkstyle issues in tests
commit 6f42a36e90b2b82577621a6e54a6a4fdd5b55e4f
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-11T15:01:20Z
[SPARK-6990] Enable Checkstyle for tests
commit 677e228f429029072cdc87770cb584de34cea63e
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-11T15:01:48Z
[SPARK-6990] Enable FallThrough check in Checkstyle
This makes sure all case statements end with a break. See
http://checkstyle.sourceforge.net/config_coding.html#FallThrough
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
