Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9686#discussion_r44812172
--- Diff:
core/src/test/scala/org/apache/spark/shuffle/hash/HashShuffleManagerSuite.scala
---
@@ -46,6 +46,7 @@ class HashShuffleManagerSuite extends SparkFunSuite with
LocalSparkContext {
// an object is written. So if the codepaths assume writeObject is end
of data, this should
// flush those bugs out. This was common bug in ExternalAppendOnlyMap,
etc.
conf.set("spark.serializer.objectStreamReset", "1")
+ conf.set("spark.shuffle.consolidateFiles", "true")
--- End diff --
@aarondav Do you remember why we did not enable consolidation in this test?
Since the title is "consolidated shuffle can write to shuffle group without
messing existing offsets/lengths" (introduced in #1678)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
