Github user markhamstra commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8923#discussion_r44844445
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -399,8 +399,8 @@ class DAGScheduler(
       }
     
       /** Find ancestor shuffle dependencies that are not registered in 
shuffleToMapStage yet */
    -  private def getAncestorShuffleDependencies(rdd: RDD[_]): 
Stack[ShuffleDependency[_, _, _]] = {
    -    val parents = new Stack[ShuffleDependency[_, _, _]]
    +  private def getAncestorShuffleDependencies(rdd: RDD[_]): 
Set[ShuffleDependency[_, _, _]] = {
    --- End diff --
    
    Please return an immutable Set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to