Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9642#issuecomment-156697230
> You mean discard change and only update documentation? Yes this is one
option - I even think that it is not so bad.
I would only update the documentation. Internal mutable rows are among the
most performance critical classes in Spark SQL, so I am not that keen to add
(potentially unnecessary) branching to every primitive getter. When someone is
using ```InternalRow```s he or she is using a SparkSQL internal API anyway, and
really should be knowing what (s)he is doing.
> You mean problem caused by not introducing this change?
Yes, do you know any other problems caused by this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
