Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1308#discussion_r14572630
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/json/JsonSuite.scala
---
@@ -448,9 +448,9 @@ class JsonSuite extends QueryTest {
}
test("Type conflict in array elements") {
- val jsonSchemaRDD = jsonRDD(arrayElementTypeConflict)
+ var jsonSchemaRDD = jsonRDD(arrayElementTypeConflict1)
- val expectedSchema =
+ var expectedSchema =
--- End diff --
Is this just a separate test you are adding? Seems like bad form to make
these vars and reuse the variable name if not absolutely required.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
