Github user tedyu commented on the pull request:

    https://github.com/apache/spark/pull/9253#issuecomment-156834018
  
    Should mapPartitions() be replaced with mapPartitionsInternal() in the 
following classes ?
    ```
        child.execute().mapPartitions { iter =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregate.scala
        val rootType = schemaData.mapPartitions { iter =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/InferSchema.scala
        json.mapPartitions { iter =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
        rows.mapPartitions { iterator =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JSONRelation.scala
            .mapPartitions { iterator =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala
          .mapPartitions { iter =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/DefaultSource.scala
          child.execute().mapPartitions { iter =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/debug/package.scala
        data.mapPartitions { iterator =>
        data.mapPartitions { iterator =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala
        child.execute().mapPartitions { iter =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/Expand.scala
        streamedPlan.execute().mapPartitions { streamedIter =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala
        streamedPlan.execute().mapPartitions { streamedIter =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashOuterJoin.scala
        val matchesOrStreamedRowsWithNulls = streamed.execute().mapPartitions { 
streamedIter =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoin.scala
        streamed.execute().mapPartitions { streamedIter =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/LeftSemiJoinBNL.scala
        rdd.mapPartitions { iter =>
        inputRDD.mapPartitions { iter =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/python.scala
        child.execute().mapPartitions { iter =>
        child.execute().mapPartitions { iter =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/rowFormatConverters.scala
        child.execute().mapPartitions { iter =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/sort.scala
        child.execute().mapPartitions { stream =>
    
/Users/tyu/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala
    ```
    If so, allow me to open a PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to