Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9724#discussion_r44883803
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/InferSchema.scala
 ---
    @@ -25,33 +25,36 @@ import 
org.apache.spark.sql.execution.datasources.json.JacksonUtils.nextUntil
     import org.apache.spark.sql.types._
     import org.apache.spark.util.Utils
     
    -private[sql] object InferSchema {
    +
    +private[json] object InferSchema {
    +
       /**
        * Infer the type of a collection of json records in three stages:
        *   1. Infer the type of each record
        *   2. Merge types by choosing the lowest type necessary to cover equal 
keys
        *   3. Replace any remaining null fields with string, the top type
        */
    -  def apply(
    +  def infer(
    --- End diff --
    
    it is super confusing for apply to return RDD (i.e. it is not a factory 
method).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to