Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9726#discussion_r44889853
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala
---
@@ -288,14 +287,13 @@ case class WrapOption(optionType: DataType, child:
Expression)
throw new UnsupportedOperationException("Only code-generated
evaluation is supported")
override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode):
String = {
- val javaType = ctx.javaType(optionType)
val inputObject = child.gen(ctx)
s"""
${inputObject.code}
boolean ${ev.isNull} = false;
- scala.Option<$javaType> ${ev.value} =
+ scala.Option ${ev.value} =
--- End diff --
Janino doesn't support generic type, so we don't need to pass in the
`optionType`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
