GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/9728

    [SPARK-11752][SQL] fix timezone problem for DateTimeUtils.getSeconds

    code snippet to reproduce it:
    ```
    TimeZone.setDefault(TimeZone.getTimeZone("Asia/Shanghai"))
    val t = Timestamp.valueOf("1900-06-11 12:14:50.789")
    val us = fromJavaTimestamp(t)
    assert(getSeconds(us) === t.getSeconds)
    ```
    
    it will be good to add a regression test for it, but the reproducing code 
need to change the default timezone, and even we change it back, the `lazy val 
defaultTimeZone` in `DataTimeUtils` is fixed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark seconds

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/9728.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9728
    
----
commit afc966412f9ac13f79738e2747e434dd531c0674
Author: Wenchen Fan <[email protected]>
Date:   2015-11-16T06:20:32Z

    fix timezone problem for getSeconds

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to