Github user choochootrain commented on a diff in the pull request:
https://github.com/apache/spark/pull/9367#discussion_r44967864
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -78,15 +79,15 @@ private[spark] object TestUtils {
}
/**
- * Create a jar file that contains this set of files. All files will be
located at the root
- * of the jar.
+ * Create a jar file that contains this set of files. All files will be
located in the specified
+ * directory or at the root of the jar.
*/
- def createJar(files: Seq[File], jarFile: File): URL = {
+ def createJar(files: Seq[File], jarFile: File, directoryPrefix:
Option[String] = None): URL = {
--- End diff --
afaik you cannot import a class from a jar unless it has declared a package
and the `.class` resides in the corresponding directory in the jar.
without `directoryPrefix`, `createJar` will place all of your classes into
the root directory of the jar so you cannot actually import anything from them.
it looks like this is the first use of `createJar` in the tests that goes on to
load classes from the jar so there was no need for this before.
in the spirit of keeping this change as minimal as possible, i added a
`directoryPrefix` option but i am open to other suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
