Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/9697#discussion_r44972401
--- Diff:
tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala ---
@@ -72,7 +72,10 @@ object GenerateMIMAIgnore {
val classSymbol = mirror.classSymbol(Class.forName(className,
false, classLoader))
val moduleSymbol = mirror.staticModule(className)
val directlyPrivateSpark =
- isPackagePrivate(classSymbol) ||
isPackagePrivateModule(moduleSymbol)
+ isPackagePrivate(classSymbol) ||
+ isPackagePrivateModule(moduleSymbol) ||
+ classSymbol.isPrivate ||
+ classSymbol.isProtected
--- End diff --
About your previous question, yes, `isPrivate` catches some classes that we
did not catch previously (because we were checking for package-private classes,
not private classes).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
